Remove redundant boolean state from LongDecimalWithOverflowAndLongState#16667
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Mar 25, 2023
Merged
Remove redundant boolean state from LongDecimalWithOverflowAndLongState#16667raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
sopel39
reviewed
Mar 22, 2023
|
|
||
| // for copying | ||
| private SingleLongDecimalWithOverflowAndLongState(long longValue) | ||
| private SingleLongDecimalWithOverflowAndLongState(long[] unscaledDecimal, long longValue, long overflow) |
Member
There was a problem hiding this comment.
I don't understand. Was this a bug? It wasn't delegating to super constructor.
Does this deserve a separate commit/PR?
Member
Author
There was a problem hiding this comment.
It looked like a mistake in the current code to me but I don't know enough about how it is used to definitively say whether it would've resulted in a bug.
@kasiafi could you please take a look and clarify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant boolean state from LongDecimalWithOverflowAndLongState
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: